Set per-field values for the maximum length of multi-token matches#96
Open
Gray-Davidson-00 wants to merge 9 commits intomasterfrom
Open
Set per-field values for the maximum length of multi-token matches#96Gray-Davidson-00 wants to merge 9 commits intomasterfrom
Gray-Davidson-00 wants to merge 9 commits intomasterfrom
Conversation
moredatarequired
requested changes
Oct 7, 2020
moredatarequired
left a comment
moredatarequired
left a comment
There was a problem hiding this comment.
Thank you! Once you take out the hardcoded check for advertiser it's all done. (as of right now we skip the value we get out of the dictionary if it's not an advertiser)
moredatarequired
changed the title
This reverts commit f8c4f76.
Co-authored-by: Hugh Wimberly <hugh.wimberly@gmail.com>
Co-authored-by: Hugh Wimberly <hugh.wimberly@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hugh, I added a dictionary to contain all five max_token_count values. I estimated liberal defaults for all 5. The correct value for max_token_count is employed in label_tokens below. This bypasses the work you did to pass max_token_count as an argument but I couldn't easily figure out how to pass in a dictionary of values. In any case, modifying the dictionary at the top of the file should do what we want here.